Optimisation: Prevent creating multiple ws connections on client #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToufeeqP
changed the title
markopoloparadox
approved these changes
Sep 10, 2024
markopoloparadox
force-pushed
the
toufeeq/fix-rust-interfaces
branch
from
66d458d
to
316d3b8
Compare
| let mut params = RpcParams::new(); | ||
| params.push(cells)?; | ||
| params.push(block_hash)?; | ||
| let actual_proof: Vec<GDataProof> = client.rpc().request("kate_queryProof", params).await?; |
There was a problem hiding this comment.
As side-effect, this also remove the capability of use the RPC with type safety.
I think it is not a good a Rusty-approach, because any future change in RPC on future release will be hardly detected on Rust clients.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Description
Preventing rust interfaces from creating multiple ws connections for a single client.
BREAKING CHANGE:
This is a breaking change in avail-subxt as it removes
rpc_methodsfrom theAvailClient.Checklist
cargo test.cargo fmt.cargo build --releaseandcargo build --release --features runtime-benchmarks.cargo clippy.